elastic/elasticsearch

Add resource ID to 404 response body

Open

#82,675 opened on Jan 17, 2022

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Core/Infra/Core>enhancementTeam:Core/Infrahelp wanted

Description

It would be very useful to be able to easily extract the id of the resource thats not found from the body of a 404 request. I believe this would involve adding the ID to ResourceNotFoundException.

Contributor guide

Tech stack
javarest api
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of JavaFamiliarity with Elasticsearch exception handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `ResourceNotFoundException` class in the Elasticsearch codebase. Look at how exceptions are mapped to HTTP responses, likely in REST handlers. The change involves including the resource ID in the response body when a 404 occurs. Review existing tests for 404 responses to ensure proper handling. Consider discussing with maintainers on the preferred approach for including the ID.