elastic/elasticsearch

Unable to unset index.blocks.read_only without index. prefix

Open

#48,325 opened on Oct 22, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Core/Infra/Settings>bugTeam:Core/Infrahelp wantedtriaged

Description

Elasticsearch version (bin/elasticsearch --version): 7.3.2 / 7.4.0

Description of the problem including expected versus actual behavior:

After creating an index with blocks.read_only set to true, it was nearly impossible to unset the setting (in order to delete or close the index) until it was pointed out to try it with the index. prefix.

Steps to reproduce:

1. Create an index with blocks.read_only set to true

PUT /test
{
  "settings": {
    "blocks.read_only": true
  }
}

2. Attempt to unset it with blocks.read_only set to false or null (or attempt to close or delete the index without setting it, which by design it's blocked, but I am including these to help people find this issue).

PUT /test/_settings
{
  "blocks.read_only": null
}

3. Unset it with index.blocks.read_only set to false or null

PUT /test/_settings
{
  "index.blocks.read_only": null
}

Contributor guide

Tech stack
javarest api
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Elasticsearch index settingsHTTP PUT requests
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the handling of index settings prefix in the Elasticsearch REST API. Look at the code that processes update settings requests, likely in the `IndexSettings` class or related REST action. The issue suggests that when unsetting `blocks.read only` without the `index.` prefix, it fails silently or does not apply. Check if there is a validation that strips the prefix in some cases but not others. Test by creating an index with `blocks.read only` set and then trying to unset via ` settings` API without prefix. Check existing tests for update settings to see if this case is covered.