elastic/elasticsearch

Update API: Setting ctx.op to random string results in noop

Open

#43,514 opened on Jun 22, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Distributed/CRUDTeam:Distributedhelp wanted

Description

Elasticsearch version (bin/elasticsearch --version): 7.1.1

Description of the problem including expected versus actual behavior:

When using a script in the Update API, setting ctx.op to any string will result in a noop. IMO this should throw an exception, if it's anything else than the suggested ones.

This leniency is actually documented with a TODO, but I do not know the history behind that (that todo is from early 2017). Also a warn message is logged.

Steps to reproduce:

DELETE test

PUT test/_doc/1
{
  "key" : "value"
}

POST test/_update/1
{
  "script": {
    "source": "ctx._source.foo = 'bar'; ctx.op ='anything'",
    "lang": "painless"
  }
}

# document unchanged
GET test/_doc/1

Contributor guide

Tech stack
javarest api
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaElasticsearch Update API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Look at UpdateHelper.java around line 372 where the TODO is located. Implement a check that throws an exception if ctx.op is set to a string other than the allowed values ('noop', 'delete', 'index'). The existing code logs a warning, so you may need to replace that with an exception. Ensure to test with valid and invalid values. Consider also updating the documentation if needed.