elastic/elasticsearch

Reindex requests do not implement x-content testing

Open

#43,456 opened on Jun 20, 2019

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Java (76,700 stars) (25,882 forks)batch import
:Distributed/Reindex>tech-debt>testTeam:Distributedgood first issuev9.5.0

Description

Currently the three primary reindex plugin requests do not implement our standard AbstractXContentTestCase testing infrastructure. This infrastructure would have detected issues like #43406.

The requests in need are:

  • UpdateByQueryRequest
  • ReindexRequest
  • DeleteByQueryRequest

Contributor guide

Tech stack
java
Domain
backendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java programmingElasticsearch architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Study how ReindexRequest already implements AbstractXContentTestCase (as marked done). Then implement the same testing pattern for UpdateByQueryRequest and DeleteByQueryRequest, following the existing serialization and parsing logic. Ensure the tests cover round trip serialization and edge cases.