elastic/elasticsearch

Consistency between `_search` and `_msearch`

Open

#4,227 opened on Nov 21, 2013

View on GitHub
 (42 comments) (1 reaction) (0 assignees)Java (25,882 forks)batch import
:Search Foundations/Search>bugTeam:Search Foundationsgood first issuehelp wantedpriority:normal

Repository metrics

Stars
 (76,700 stars)
PR merge metrics
 (Avg merge 2d) (1,000 merged PRs in 30d)

Description

The _msearch API doesn't accept the same header parameters than _search's query parameters. For instance version is both valid in the search body and query parameters for _search, but is ignored in the query parameters and header in _msearch.

MultiSearchRequest.add() should rely on RestSearchAction.parseSearchSource() or even RestSearchAction.parseSearchRequest() to parse the subrequests, for maximum compatibility.

IMHO, a clean bulk API should use the header parameters as query parameters on the target endpoint, which would imply that they keep in sync no matter the code changes in the target endpoints.

Contributor guide

Research direction
Compare the parameter handling in search and msearch APIs, then modify MultiSearchRequest.add() to use RestSearchAction.parseSearchSource() or parseSearchRequest() for parsing subrequests, ensuring header parameters are treated consistently.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70