elastic/elasticsearch

Authentication stream version check exists in 5.x only

Open

#29,849 opened on Jan 5, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Security/Authentication>enhancementTeam:Securityhelp wanted

Description

Original comment by @tvernum:

In LINK REDACTED a LINK REDACTED was added to Authentication to ensure that the version of the serialized authentication matches the version of the connection it's being read from.

This check is in 5.x but is not in 6.x or master.

It's being triggered in LINK REDACTED due to what seems to be a real versioning issue in CCS, but the problem the customer is seeing doesn't occur in 6.x because the check isn't there (the version mismatch exists, it just doesn't throw any exceptions)

Do we want to add that check in to 6.x and 7.x ?

Contributor guide

Tech stack
java
Domain
authenticationsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Java knowledgeElasticsearch authentication internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the 5.x commit that added the authentication version check, likely in the Authentication class. Understand the CCS version mismatch triggering issue #29849 and determine if the same check should be backported to 6.x and 7.x. Review any linked comments or PRs for context, then propose a patch for both branches.
Authentication stream version check exists in 5.x only · elastic/elasticsearch#29849 | Good First Issue