elastic/elasticsearch

Add ingest processor to percolator that rewrites queries

Open

#29,053 opened on Mar 14, 2018

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Search Relevance/Percolator>bugTeam:Search Relevancehelp wantedpriority:normal

Description

Follow up from #17071

The percolator needs a ingest processor that performs the QueryBuilder rewrite. At the moment the query builder rewrite happens in the PercolatorFieldMapper which means each shard copy performs this rewrite. Most of the time this isn't a problem, but in the case that a query builder does a remote fetch (geo_shape query using indexed shape) there is a chance that the query builder rewrite that each shard copy forms fetch slightly different values.

Contributor guide

Tech stack
java
Domain
backendsearch
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of Elasticsearch percolatorJava programmingUnderstanding of QueryBuilder rewrite
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
Investigate the current implementation in PercolatorFieldMapper that performs QueryBuilder rewrite. Review the linked issue #17071 for context. Design an ingest processor that handles the rewrite, ensuring that remote fetches (as in geo shape query) are performed at ingest time rather than per shard copy. Consider the existing ingest processor infrastructure and how to integrate the new processor.