elastic/elasticsearch

Repository settings are not validated

Open

#27,765 opened on Dec 11, 2017

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Distributed/Snapshot/Restore>bug>tech-debtTeam:Distributedhelp wanted

Description

Creating a repository consumes known settings, but does not error in invalid settings. This is especially a problem starting in 6.0 as we deprecated in 5.x and then removed in 6.0 a number of repository settings, including endpoint. This can be confusing for a user that had a working repo, but the setting is no longer valid, yet they get no error message.

Contributor guide

Tech stack
javarest api
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of Elasticsearch repository settingsJava basicstesting with Elasticsearch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the repository creation code in Elasticsearch (likely in the `org.elasticsearch.repositories` package). Check for validation logic in `RepositorySettings` or similar classes. Look at the deprecated settings handling in version 6.0. Consider adding validation during repository creation and providing clear error messages for invalid settings. The issue mentions the 'endpoint' setting as an example; trace how settings are parsed and consumed.
Repository settings are not validated · elastic/elasticsearch#27765 | Good First Issue