elastic/elasticsearch

Should reindex serialize partial index and search requests

Open

#22864 opened on Jan 30, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Distributed/Reindex>bugTeam:Distributedhelp wanted

Description

As part of https://github.com/elastic/elasticsearch/pull/22691#discussion_r98434085, we noticed some behavior that deviates from the normal assumptions of serializing requests when using reindex. @javanna said:

we always make the assumption that serialization relies on the request being valid according to validate I think.

Based on that statement (valid means validate passes), the way reindex serializes a search request and index request violates the assumption. Should we consider removing the use of these partial requests and just serialize the data we expect for reindex?

Contributor guide

Tech stack
java
Domain
backend
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Elasticsearch serializationReindex APIRequest validation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the ReindexRequest serialization code to understand how it currently creates partial search and index requests. Examine the assumptions around validation and serialization as discussed in PR #22691. Verify if using complete request objects is feasible and what changes are needed.