elastic/elasticsearch

Add took to update's response

Open

#22573 opened on Jan 11, 2017

View on GitHub
 (19 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Distributed/CRUD>enhancementTeam:Distributedhelp wanted

Description

Sorry if this is already covered somewhere else, I looked through a bunch of issues and couldn't find it.

update's response does not include took like index's does. Is there a reason for this? If not, can it please be added? Using version 5.1.1.

Contributor guide

Tech stack
javarest api
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Java knowledgeFamiliarity with Elasticsearch response classes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding a 'took' field to the update response, similar to the index response. First, examine how the index response includes 'took' by looking at the IndexResponse class or its builder. Then, locate the UpdateResponse class (likely in modules/ingest common or core/src/main/java/org/elasticsearch/action/update) and add a 'took' field. Ensure the field is populated using the time taken for the update operation. Refer to the existing implementation in IndexResponse for guidance. No linked PRs or comments provide specific file paths, so you'll need to search the repository for UpdateResponse.