elastic/elasticsearch

Detect when copying to a non-existent field when dynamic mappings are disabled

Open

#112,812 opened on Sep 12, 2024

View on GitHub
 (20 comments) (0 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Search Foundations/Mapping:Search Relevance/Search>enhancementTeam:Search FoundationsTeam:Search Relevancegood first issue

Description

Description

We should be able to detect when a user is attempting to use copy_to to copy to a non-existent field when dynamic mappings are disabled. For example:

PUT test-index
{
  "mappings": {
    "dynamic": false,
    "properties": {
      "test_field": {
        "type": "text",
        "copy_to": "missing_field"
      }
    }
  }
}

Currently, this request succeeds even though nothing will ever be copied to missing_field. We should throw a 400 error in this case to indicate to the user that their mappings are invalid.

Contributor guide

Tech stack
javarest api
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaElasticsearch mapping conceptsUnderstanding of dynamic mapping
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the mapping parsing code where copy to is handled, likely in classes like MappingMetaData or FieldMapper. Examine the logic that validates field existence when dynamic is false. Consider how to integrate a check that throws an exception. Review the existing test suite for mapping validation to understand patterns. Check the issue comments for any suggested approaches.