Weird methods in ElasticsearchClient

Open
#145 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
elasticsearch, java
Domain
backend-api-design, search

Research direction

Start with the cited methods in java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchClient.java and compare their generated signatures with the Elasticsearch API specification. Determine whether the no-argument overloads should be removed, then verify that the affected client methods and any generated output consistently reflect the required parameters.

Written by the indexing model from the issue text.

Description

Category: Enhancement

There are methods in ElasticsearchClient that look like not very useful.

They do not take any parameter, therefore using the builder internally without setting any value. When called, they raise an IllegalStateException.

Examples

Looking at the API documentation, there is a least some mandatory parameter.

Is this maybe the result of generating the client based on the API specification and they should better be removed?

Dominant language
Java
Stars
524
Forks
300
Avg merge
1d 11h
Merged PRs (30d)
16

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from elastic/elasticsearch-java

All issues in elastic/elasticsearch-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.