Amazon SNS service -> service name includes topic

Open Beginner friendly
#1,511 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
aws, ruby
Domain
observability

Research direction

Review lib/elastic_apm/spies/sns.rb at lines 66-71, where the Amazon SNS resource is set. Confirm how the service name is built, then change it so multiple topics share one SNS service name rather than including subtype/topic_id; done means the rendered service graph has a single SNS service.

Written by the indexing model from the issue text.

Description

agent-ruby bug

Hi,

While looking at our dependencies, I found that Amazon SNS service's name is equal to subtype/topic_id. You can imagine having multiple topic what kind of graph is rendered. I think having 1 service SNS would be enough for most cases.

The resource is set here and I would gladly open a PR to change it.

Thanks.

Dominant language
Ruby
Stars
173
Forks
151
Avg merge
4d 8h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from elastic/apm-agent-ruby

All issues in elastic/apm-agent-ruby

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.