egoist/nwjs

32/64bits specified?

Open

#13 opened on Apr 28, 2016

View on GitHub
 (2 comments) (6 reactions) (0 assignees)JavaScript (76 stars) (19 forks)user submission
enhancementhelp wanted

Description

const fileName = version == realVersion ? `nwjs-v${realVersion}-${os.platform}-${os.arch}`

Currently it totally depends on os.arch, so does https://github.com/nwjs/npm-installer/issues/28. Unfortuately I need this feature :/ Our app is to be distributed in 32bits, so I need a 32bit version as well as 64 in my machine.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScriptUnderstanding of nw.js release structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the codebase, likely in index.js or a download script, to understand how the architecture (os.arch) is currently used. Add a new option (e.g., ' arch' or 'arch' in config) to allow users to specify 32 bit or 64 bit. Consider cross platform handling and defaulting to os.arch if not specified. Check related issue #28 for additional context. Implement the change and update documentation.