egoist/devdocs-desktop

Refactor auto-updater

Open

#117 opened on Mar 7, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,106 stars) (193 forks)user submission
contribution welcomeenhancementhelp wanted

Description

Now the Mac app is signed so we can now use auto-updater on Mac, previously we only show an alert for new version. We need to remove legacy code and ensure the new auto updater is working.

Contributor guide

Tech stack
javascriptelectron
Domain
desktop
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with Electron's auto updaterbasic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look into the current auto updater implementation in the codebase, likely in the main process files. Check the legacy code that shows an alert and the new signed Mac app support. Ensure that the new auto updater is properly triggered and tested on Mac. The issue mentions removing legacy code, so identify and remove the old alert based update notification flow.
Refactor auto-updater · egoist/devdocs-desktop#117 | Good First Issue