edgurgel/solid

break and continue with whitespace control issue

Open

#86 opened on Sep 6, 2021

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Elixir (56 forks)github user discovery
bughacktoberfest

Repository metrics

Stars
 (257 stars)
PR merge metrics
 (Avg merge 17d 10h) (2 merged PRs in 30d)

Description

     Render result was different!
     Input:
     ########################

     this should print

     {%- break -%}

     this should not print

     ########################


     code:  liquid_output == solid_output
     left:  "########################\n\nthis should print\n"
     right: "########################\n\nthis should print"

     Render result was different!
     Input:
     ########################

     this should print

     {%- continue %}

     this should not print

     ########################


     code:  liquid_output == solid_output
     left:  "########################\n\nthis should print\n"
     right: "########################\n\nthis should print"

https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/break_tag_test.exs#L3-L15 & https://github.com/edgurgel/solid/blob/master/test/integration/whitespace_control_cases/continue_tag_test.exs#L3-L15

Contributor guide

Research direction
Examine the whitespace control logic for break and continue tags in the parser. Check how the whitespace stripping is applied and ensure it behaves consistently with other similar tags.
Tech stack
elixir
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElixirGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80