Rename `showResizeFeedback` and `eraseResizeFeedback` in AbsoluteBasedLayoutEditPolicy

Open
#1,627 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
70/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
java
Domain
tooling

Research direction

Start with org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/policy/layout/absolute/AbsoluteBasedLayoutEditPolicy.java and compare its feedback methods with the GEF API. Then inspect AbsoluteBasedSelectionEditPolicy.java at the linked lines and verify the resize-request handling. Done means the methods use the requested names, resize requests are checked explicitly, and the obsolete workaround is removed.

Written by the indexing model from the issue text.

Description

They should be called showSourceFeedback and eraseSourceFeedback to match the GEF API. We need to explicitly check whether the request type is AbsoluteBasedSelectionEditPolicy.REQ_RESIZE. This then also makes the workaround in the AbsoluteBasedSelectionEditPolicy obsolete.

https://github.com/eclipse-windowbuilder/windowbuilder/blob/98b82d173da11c00a0df11eb4442c59c9bee7cad/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/policy/layout/absolute/AbsoluteBasedSelectionEditPolicy.java#L75-L87

Dominant language
Java
Stars
97
Forks
34
Avg merge
1d 2h
Merged PRs (30d)
38

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eclipse-windowbuilder/windowbuilder

All issues in eclipse-windowbuilder/windowbuilder

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.