mqv:filter is silently ignored due to operator precedence bug
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- networking
Research direction
Search the TypeScript source for requestUri.pathname.slice(1) and mqv:filter to locate the request and filter handling entry point. Reproduce the root-URL case with the shown form and verify that the filter is preserved when the pathname slice is empty; add or update a regression test if the surrounding code has tests.
Written by the indexing model from the issue text.
Description
the mqv:filter is being "silently ignored" in cases where requestUri.pathname.slice(1) returns an empty string "" (which is falsy), but the nullish coalescing operator ?? only triggers on null or undefined, not on empty strings.
foexample:
URL: mqtt://broker.example.com/
Form has: { "mqv:filter": "sensors/+/temperature" }
Current behavior:
requestUri.pathname = "/"
requestUri.pathname.slice(1) = "" (empty string, not null/undefined)
filter = "" (mqv:filter is ignored!)
Expected behavior:
filter should be "sensors/+/temperature"
- Dominant language
- TypeScript
- Stars
- 193
- Forks
- 100
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 12
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eclipse-thingweb/node-wot
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
eclipse-thingweb/node-wot#1495 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
eclipse-thingweb/node-wot#1563 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
eclipse-thingweb/node-wot#1532 ·
-
binding-http Discuss in Committer Meeting
Difficulty 4/5 3-5 days Newbie friendliness 48/100
eclipse-thingweb/node-wot#1522 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
eclipse-thingweb/node-wot#1509 ·
All issues in eclipse-thingweb/node-wot
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100