eclipse-theia/theia

VSCode extension icons are not loaded when a path is added to base URL

Open

#9,596 opened on Jun 16, 2021

View on GitHub
 (14 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
help wantedvscode

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Bug Description:

Steps to Reproduce:

  1. Run sample browser-app with a vscode extension. I'm using docker for vscode extension which I got from the public github.
  2. Open http://localhost:3000
  3. Plugin will be loaded with the icon on the activity bar: Screen Shot 2021-06-15 at 5 49 14 PM
  4. Open http://localhost:3000/index.html , you'll observe that icon wouldn't be loaded. Screen Shot 2021-06-15 at 8 55 29 PM Network call:

Request URL: http://localhost:3000/index.html/hostedPlugin/docker_vscode/resources/activity-bar-icon.svg Request Method: GET Status Code: 404 Not Found

If you see the above get URL, extension is using http://localhost:3000/index.html as the base URL to fetch the extension assets. How do we configure theia to ignore index.html in the path while fetching the assets for an extension?

Additional Information

  • Operating System: OSX
  • Theia Version: 0.14.0

Contributor guide

Research direction
Investigate how Theia resolves plugin resource URLs when a base path is present. Trace asset path construction in the plugin host or resource loading code to find where index.html is incorrectly prepended. Look for URL joining logic that assumes a root relative path instead of handling a base path with a filename.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptWeb development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60