eclipse-theia/theia

fail to exit js debug session with `integratedTerminal` mode

Open

#9509 opened on May 24, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
debughelp wanted

Description

Bug Description:

when I start a new js debug session with integratedTerminal mode, when the js process exits, there is still a debug session in the THREADS widget

Steps to Reproduce:

  1. add a new js debug configuration
  2. because the default console is internalConsole, we should add "console": "integratedTerminal" to the config
  3. create a simple js file which could only contains a single console log line
  4. start the debug session until the js file is exited
  5. you can notice there is a session remains in the THREADS widget
  6. you need to manually stop the remaining session to clean it

Additional Information

  • Operating System: ubuntu
  • Theia Version: 1.13.0
  • js-debug plugin version: 1.49.8

Contributor guide

Tech stack
typescriptjavascriptnodejs
Domain
developer experiencebackendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript debugger conceptsTheia IDE basicsNode.js debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the behavior of debug session termination when using 'integratedTerminal' console mode. Look at the Theia debugger extension code, particularly in the 'packages/debug' directory and the 'plugins/js debug' plugin. Compare the lifecycle for 'internalConsole' vs 'integratedTerminal' to find where the session persists. Check if there is an event or cleanup that is missing for terminal based debugging. The issue may require understanding how the debug adapter protocol handles session end events in terminal mode.