eclipse-theia/theia

ui: better support for icons in sidepanels

Open

#9,061 opened on Feb 12, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
editorhelp wantedmarkersui/ux

Description

Bug Description:

The goal is to have better (more uniform) support for icons present in the sidepanels, namely for docked editors. Currently, when problems.decorations.tabbar.enabled is enabled, editors with warnings or errors are not displayed correctly or consistently for different file-icon themes:

theia icon Screenshot_2021-02-12_11-01-47

none: (https://github.com/eclipse-theia/theia/issues/7038) Screenshot_2021-02-12_11-02-21

seti: Screenshot_2021-02-12_11-02-36

Steps to Reproduce:

  1. start the application and make sure that problems.decorations.tabbar.enabled is enabled
  2. open a json editor, create error markers and dock the editor in the sidepanel
  3. change the file-icon theme (F1 + Preferences: File Icon Theme)

Contributor guide

Tech stack
typescriptcsselectron
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of Theia's icon theme systemFamiliarity with sidepanel widget code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the sidepanel tab decoration code in the Theia repository, particularly around the problems.decorations.tabbar.enabled feature. Look at how file icons are applied to docked editors and compare behavior across different icon themes. Check relevant source files in packages/editor and packages/sidepanel for inconsistencies.