eclipse-theia/theia

Issue with multiple comments with Github Pull request plugin

Open

#9007 opened on Jan 30, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedvscode

Description

Bug Description:

Start Review and Add comment buttons behaves same across multiple comments dialog

Steps to Reproduce:

  1. Refer the steps given in https://github.com/eclipse-theia/theia/pull/8870
  2. Open a file with multiple changes
  3. Open and add reply in both the discussion
  4. Remove the content from one discussion and notice the buttons of both discussion changes

https://user-images.githubusercontent.com/13016475/106349492-34a98800-62f4-11eb-8c4e-3facc77af18b.mov

Additional Information

  • Theia Version: Version 1.10.0

Contributor guide

Tech stack
typescriptreactnodejs
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic knowledge of Theiaunderstanding of GitHub pull request plugin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue describes that the 'Start Review' and 'Add comment' buttons behave the same across multiple comment dialogs. The steps reference PR #8870. To fix, investigate the plugin code likely located in packages/git or plugins/github. Look for event handling that couples button states incorrectly. Check the linked PR for context on recent changes.