eclipse-theia/theia

Error: Connection got disposed on exit the browser

Open

#8939 opened on Jan 12, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
corehelp wantedlogging

Description

Bug Description:

When a user close the browser we get this error:

Error: Connection got disposed.
    at Object.dispose (/theia/node_modules/vscode-jsonrpc/lib/main.js:904:25)
    at /theia/node_modules/vscode-ws-jsonrpc/lib/socket/connection.js:14:41
    at CallbackList.invoke (/theia/node_modules/vscode-jsonrpc/lib/events.js:62:39)
    at Emitter.fire (/theia/node_modules/vscode-jsonrpc/lib/events.js:121:36)
    at closeHandler (/theia/node_modules/vscode-jsonrpc/lib/main.js:240:26)
    at CallbackList.invoke (/theia/node_modules/vscode-jsonrpc/lib/events.js:62:39)
    at Emitter.fire (/theia/node_modules/vscode-jsonrpc/lib/events.js:121:36)
    at WebSocketMessageReader.fireClose (/theia/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
    at WebSocketMessageReader.fireClose (/theia/node_modules/vscode-ws-jsonrpc/lib/socket/reader.js:67:19)
    at /theia/node_modules/vscode-ws-jsonrpc/lib/socket/reader.js:24:18

I found this issue on the vscode-jsonrpc package that may be connected.

Steps to Reproduce:

  1. Run server locally
  2. Open theia in the browser
  3. Close theia browser
  4. See the error on the server logs

Additional Information

  • Operating System: Local
  • Theia Version: master

Contributor guide

Tech stack
typescriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the error occurring on browser close. The stack trace points to the JSON RPC connection handling in vscode jsonrpc. Review the close sequence in the server's WebSocket connection, possibly related to the referenced issue (microsoft/vscode languageserver node#639). Look for missing cleanup or race condition when the browser closes.