Error: Connection got disposed on exit the browser · eclipse-theia/theia#8939

(5 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import

corehelp wantedlogging

Repository metrics

Stars: (18,676 stars)
PR merge metrics: (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Bug Description:

When a user close the browser we get this error:

Error: Connection got disposed.
    at Object.dispose (/theia/node_modules/vscode-jsonrpc/lib/main.js:904:25)
    at /theia/node_modules/vscode-ws-jsonrpc/lib/socket/connection.js:14:41
    at CallbackList.invoke (/theia/node_modules/vscode-jsonrpc/lib/events.js:62:39)
    at Emitter.fire (/theia/node_modules/vscode-jsonrpc/lib/events.js:121:36)
    at closeHandler (/theia/node_modules/vscode-jsonrpc/lib/main.js:240:26)
    at CallbackList.invoke (/theia/node_modules/vscode-jsonrpc/lib/events.js:62:39)
    at Emitter.fire (/theia/node_modules/vscode-jsonrpc/lib/events.js:121:36)
    at WebSocketMessageReader.fireClose (/theia/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
    at WebSocketMessageReader.fireClose (/theia/node_modules/vscode-ws-jsonrpc/lib/socket/reader.js:67:19)
    at /theia/node_modules/vscode-ws-jsonrpc/lib/socket/reader.js:24:18

I found this issue on the vscode-jsonrpc package that may be connected.

Steps to Reproduce:

Run server locally
Open theia in the browser
Close theia browser
See the error on the server logs

Additional Information

Operating System: Local
Theia Version: master

Contributor guide

Research direction: Investigate the vscode jsonrpc connection disposal handler when the browser closes and implement a graceful shutdown or ignore the error after disposal.
Tech stack: typescript
Domain: backend
Issue type: Bug
Difficulty: 2
Estimated time: 1-3 hours
Activity status: Active
Clarity: Clear
Prerequisites: Node.jsTypeScript
Newbie friendliness: 70