eclipse-theia/theia

OnDidChangeBreakpoints() doesnt work the same way in theia as in vscode

Open

#8,851 opened on Dec 10, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
debughelp wantedvscode

Description

Notification about added, removed, or changed breakpoints received via onDidChangeBreakpoints() doesn't work the same way in theia as in vs code. Only added and removed breakpoints objects were returned via event when the condition of the breakpoint (for conditional breakpoint)in the debug editor was changed .

Steps to Reproduce:

1 Try using onDidChangeBreakpoints() from vscode extension.

vscode.debug.onDidChangeBreakpoints( event => { console.log(event); }) 2. Open the file in editor. 3. Right Click on Breakpoint. 4.Select Edit Breakpoint and try adding an expression. 5 Event is triggered but doesn't return changed Breakpoints with the updated condition like vscode. Instead only added and removed breakpoints are returned.

This functionality was required for validating the expression of the conditional breakpoint from vscode extension even when debug event is not started.

  • Theia Version: 1.7

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of VS Code debug APIfamiliarity with Theia's debug architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Focus on the implementation of `onDidChangeBreakpoints` in Theia's debug extension. Compare with VS Code's implementation to identify where changed breakpoints (e.g., condition edits) are emitted. Look into the `DebugSession` and `BreakpointManager` classes, likely in `packages/debug/src/browser`. Check if the event only emits 'added' and 'removed' but not 'changed' breakpoints, and trace the path from breakpoint condition editing to event emission.