eclipse-theia/theia

Suggestions within logpoints not working as expected

Open

#8,825 opened on Dec 4, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (2,478 forks)batch import
bugdebughelp wantedvscode

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Bug Description:

Autocomplete suggestions within a log message when creating a logpoint have unexpected behavior.

  • Suggestions are shown without the interpolated scope ( { } )
  • When trying to add interpolation suggestions are only shown after 3 characters
  • Trying to autocomplete a found suggestion with enter does add it to the already typed characters, e.g: {myVaria}-> auto completes to {myVariamyVariable}
  • suggestions sometimes don't make sense in the scope currently working, expected suggestions don't show up

Steps to Reproduce:

  1. Open workspace on gitpod.io
  2. Add logpoint with type log message
  3. Without scope trigger suggestions (ctrl space) results in suggestions to show up
  4. Add interpolation via {} trigger suggentions again results in no suggestions

logmessage_suggest

Additional Information

  • Operating System: Win10 (Ms Edge 87.0.664.52)
  • Theia Version: Can be reproduced with the gitpod sample applications

Contributor guide

Research direction
Examine the autocomplete provider for logpoints, especially how suggestions are filtered and inserted. Look at the code responsible for handling interpolation brackets and the interaction with the editor's completion API.
Tech stack
typescript
Domain
frontenddevtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptIDE development concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65