eclipse-theia/theia

Suggestions within logpoints not working as expected

Open

#8,825 opened on Dec 4, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bugdebughelp wantedvscode

Description

Bug Description:

Autocomplete suggestions within a log message when creating a logpoint have unexpected behavior.

  • Suggestions are shown without the interpolated scope ( { } )
  • When trying to add interpolation suggestions are only shown after 3 characters
  • Trying to autocomplete a found suggestion with enter does add it to the already typed characters, e.g: {myVaria}-> auto completes to {myVariamyVariable}
  • suggestions sometimes don't make sense in the scope currently working, expected suggestions don't show up

Steps to Reproduce:

  1. Open workspace on gitpod.io
  2. Add logpoint with type log message
  3. Without scope trigger suggestions (ctrl space) results in suggestions to show up
  4. Add interpolation via {} trigger suggentions again results in no suggestions

logmessage_suggest

Additional Information

  • Operating System: Win10 (Ms Edge 87.0.664.52)
  • Theia Version: Can be reproduced with the gitpod sample applications

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of Theia extension systemFamiliarity with monaco editor or code editor autocomplete
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the logpoint suggestion provider in Theia's debug extension. Look at the interpolation logic in the suggestion widget. Reproduce the issue as described. Check if the autocomplete behavior is consistent with other editor contexts. The issue might be in the monaco editor integration layer.
Suggestions within logpoints not working as expected · eclipse-theia/theia#8825 | Good First Issue