eclipse-theia/theia

vscode: support 'custom data' for HTML / CSS

Open

#8,819 opened on Dec 3, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
help wantedvscode

Description

Bug Description:

The extensions that offer html customData aren't showing popup insight for those html tags.

Steps to Reproduce:

  1. Build the vscode extension for custom-data-sample from their vscode examples. (May need to update or remove publisher from package.json for this.)
  2. Install vsix.
  3. Restart workspace so that extension is reloaded (the customData extensions require reloads after installation so that the pacakge.json customdata stuff is read and used by the html language extensions)
  4. Create an html file
  5. Type <my-
    You should see <my-button offered in insight, but you do not.

I can offer the above vsix file for testing, or you can try some other files that do this.

Additional Information

Contributor guide

Tech stack
typescripthtmlcss
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understand custom data concept in VS CodeFamiliarity with Theia extension systemKnowledge of HTML language service
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Start by reviewing the custom data sample and vscode custom data repositories linked in the issue to understand how custom data is registered in VS Code. Then, examine Theia's HTML language support implementation (likely in packages/html or similar) to see how it handles custom data providers. The issue suggests that the custom data from extensions is not being picked up by the HTML language service. You may need to look at how Theia's monaco editor integration handles language features and compare with VS Code's implementation. Check if there is a missing registration or a different API for custom data in Theia.
vscode: support 'custom data' for HTML / CSS · eclipse-theia/theia#8819 | Good First Issue