eclipse-theia/theia

`ThemeService.getTheme(themeId)` should return undefined not default theme if a theme cannot be found

Open

#8,407 opened on Aug 20, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
help wantedquality

Description

This issue does not include a description.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptTheia theme service
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is about modifying the `getTheme` method in `ThemeService` (likely in `packages/core/src/browser/theme service.ts`) to return `undefined` instead of the default theme when the given theme ID is not found. The current behavior may be intentional, so review the comments for any discussion. Check for existing tests in the same package and ensure the change aligns with the overall API contract.