eclipse-theia/theia

tree-view: support for 'view action' commands without icons

Open

#8,246 opened on Jul 27, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
enhancementhelp wantedvscode

Description

Feature Description:

The feature is to support commands without icons as inline view-actions.

At the moment, if a command does not define an icons property and is used as an inline view action it will not be rendered in the framework. The following is supported in vscode as the label is used instead.

For example, the following command is displayed as the following:

"commands": [
  {
    "command": "nodeDependencies.refreshEntry",
    "title": "Refresh"
  }
]

Additional Information

Contributor guide

Tech stack
typescript
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
VS Code extension API knowledgeTheia tree view component structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue asks to support view actions without icons by using the command title as a fallback. Start by examining the Theia source code for tree view rendering, specifically the part that handles view actions. The issue references a sample extension (vscode tree view example label) that demonstrates the expected behavior in VS Code. Look for where icon presence is checked and modify to allow a label fallback. The fix is likely in the tree view widget or action rendering logic.