eclipse-theia/theia

Use "Broken Icon Reference" when not finding icons from contributions

Open

#8240 opened on Jul 27, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)TypeScript (18,676 stars) (2,478 forks)batch import
contributor experienceenhancementgood first issuehelp wanted

Description

Feature Description:

We have cases like this (https://github.com/eclipse-theia/theia/issues/7634) where we can't resolve an icon that is referenced in a contribution. It would be helpful to return an icon that signifies "Icon not found" and display that in the place of the desired icon. Currently, there is no indication in the UI that an icon could not be loaded and where it would be.

Contributor guide

Tech stack
typescriptreact
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Theia's icon contributions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate icon resolution in Theia's frontend, specifically the icon service (likely in packages/core/src/browser/icon service.ts). Look for where icon contributions are resolved and displayed. Consider adding a fallback icon (e.g., a 'broken' icon class) when a referenced icon cannot be found. Review related issue #7634 for context.