eclipse-theia/theia

workspace: correct the file filters for 'open workspace...'

Open

#8179 opened on Jul 15, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
dialogsfile dialoghelp wantedworkspace

Description

Bug Description:

The 'open workspace...' dialog incorrectly includes the 'all files' filter meaning that the application allows any file to be opened as a workspace which is incorrect. There is logic to reject opening the file if it is not of the correct type, but we should also adjust the filter as to not be able to choose incorrect file types.

The correct file types are the following only:

  • *.theia-workspace
  • *.code-workspace

Steps to Reproduce:

  1. start the application (browser or electron)
  2. trigger the open workspace... command
  3. notice that the all files filter is set
  4. attempt to open a file which is not correct (an error should appear)
  5. we should fix the filter to correct this issue

Contributor guide

Tech stack
typescriptjavascriptnodejs
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look for the 'open workspace' dialog implementation in the Theia frontend, likely in the workspace plugin (e.g., packages/workspace). Identify where file filters are set for the dialog and modify them to include only '*.theia workspace' and '*.code workspace'. Ensure consistency with existing rejection logic that validates workspace files.