eclipse-theia/theia

[vscode] Running example FileSystemProvider plugin has different behavior

Open

#8,167 opened on Jul 14, 2020

View on GitHub
 (9 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedvscodeworkspace

Description

Bug Description:

When trying to use example FileSystemProvider plugin the (expected) behavior on Code[1] differs from the behavior on Theia[2].

[1] Running plugin command Setup workspace with or without opened workspace creates new and empty directory with name that was passed to vscode.workspace.updateWorkspaceFolders in extension.ts. image

[2] Running plugin command Setup workspace without opened workspace throws an error Failed to update workspace folders: Error: There is not active workspace. If any folder was already opened in the workspace, the same plugin command opens new directory, but instead of named, empty one it's system's root. image

Steps to Reproduce:

  1. Clone microsoft/vscode-extension-samples
  2. Add fsprovider-sample plugin to Theia
  3. Run Theia
  4. Execute Setup workspace command from the command paletter

Additional Information

  • Operating System: Ubuntu 18.04 if running on Docker image Arch Linux, kernel 5.7.7 if running on host
  • Theia Version: Tried both release 1.3.0 and compiling akosyakov/integrate-vscode-api-7269 branch.

Contributor guide

Tech stack
typescript
Domain
backendtoolingdesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVS Code extension APITheia plugin systemGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the difference in workspace folder handling between VS Code and Theia by examining the FileSystemProvider sample and Theia's implementation of `vscode.workspace.updateWorkspaceFolders`. Look at the Theia source code, possibly in `packages/plugin ext` or related areas, to understand how workspace folders are managed. The issue references a branch `akosyakov/integrate vscode api 7269` which may contain relevant changes. Check the comments for any additional maintainer guidance.