eclipse-theia/theia

Terminal commands missing in certain instances.

Open

#8,100 opened on Jun 26, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bugcommandshelp wantedquick-open

Description

Bug Description:

The isEnabled handler for many terminal commands may be incorrect. If you give the terminal focus and use CTRL+SHIFT+P you will see commands like clear terminal, however, if you use CTRL+P then type >, you will not see this command. My thinking is that the isEnabled handler is looking at the focused widget, which in the case of CTRL+P, >, is probably the quick open.

Steps to Reproduce:

  1. Use CTRL+P, > with terminal focused, look for Terminal: Clear
  2. Use CTRL+SHIFT+P, with terminal focused, look for Terminal: Clear

Additional Information

  • Operating System: Linux lnx 5.3.0-59-generic #53~18.04.1-Ubuntu SMP Thu Jun 4 14:58:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
  • Theia Version: 1.2

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Theia's command isEnabled handlersKnowledge of widget focus in Theia
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the isEnabled handler in packages/terminal/src/browser/terminal frontend contribution.ts (line 283) to understand how it checks the currently focused widget. The issue is that when using CTRL+P, the quick open widget takes focus, hiding terminal commands. A possible fix is to check if the terminal widget is among the active widgets in the shell, not just the focused one. Review the quick open widget's focus management and ensure that the terminal commands appear when the terminal has focus or is the active tab.
Terminal commands missing in certain instances. · eclipse-theia/theia#8100 | Good First Issue