eclipse-theia/theia

Find & Replace is not fully functional for keyboard users.

Open

#8,055 opened on Jun 19, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
accessibilityhelp wantedsearch in workspace

Description

Bug Description:

In both Theia and VS Code pressing enter in the focused input(where the new value is entered in find and replace) does not replace the contents I have to manually click on the small icon next to the input. I was expecting it to work when the enter key is pressed.

Peek 2020-06-19 17-22

To me, it looks like a serious accessibility issue for Keyboard users and generally, it would be great if the whole Theia IDE is accessible for those users who only use a keyboard and can't use a mouse.

Steps to Reproduce:

  1. Open a Gitpod workspace.
  2. Try to find and replace some text via the Keyboard.

Additional Information

  • Operating System:
  • Theia Version:

Contributor guide

Tech stack
typescript
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Theia widget extensionsTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The bug is in the find/replace widget of Theia. The issue is that pressing Enter in the replace input field does not trigger the replace action; users must click the replace button. To fix, locate the widget code in the theia repository, likely under packages/editor or packages/find replace. Add a keydown event listener for Enter that programmatically clicks the replace button or triggers the replace command. Check how the replace button's click handler is bound and replicate that on Enter press.
Find & Replace is not fully functional for keyboard users. · eclipse-theia/theia#8055 | Good First Issue