eclipse-theia/theia

Find & Replace is not fully functional for keyboard users.

Open

#8,055 opened on Jun 19, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
accessibilityhelp wantedsearch in workspace

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Bug Description:

In both Theia and VS Code pressing enter in the focused input(where the new value is entered in find and replace) does not replace the contents I have to manually click on the small icon next to the input. I was expecting it to work when the enter key is pressed.

Peek 2020-06-19 17-22

To me, it looks like a serious accessibility issue for Keyboard users and generally, it would be great if the whole Theia IDE is accessible for those users who only use a keyboard and can't use a mouse.

Steps to Reproduce:

  1. Open a Gitpod workspace.
  2. Try to find and replace some text via the Keyboard.

Additional Information

  • Operating System:
  • Theia Version:

Contributor guide

Research direction
Identify the keydown handler for the replace input in the find/replace widget and add a listener for the Enter key to execute the replace action.
Tech stack
typescript
Domain
accessibility
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65