eclipse-theia/theia

Firefox debugger stays in 'debug' state if debugged window is closed or attach is cancelled

Open

#7,512 opened on Apr 7, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bugdebughelp wanted

Description

Description

When I close debugged Firefox window, debugging session in Theia remains open until Theia reload.

Reproduction Steps

  1. Install Firefox Debugger extension, I did it from .vsix I had (v2.7.0)
  2. Start debug using either launch or attach
  3. Close debugged window or press cancel in attach window
  4. See that bottom pane is still orange and debug view shows there's a session running If you stop session using button in Theia debugger disconnects from Firefox correctly. VS Code debug session with v2.7.1 of extension ends successfully when closing the browser. It doesn't look like the bug was fixed, code stayed almost the same: https://github.com/firefox-devtools/vscode-firefox-debug/compare/2.7.0...2.7.1 . Chrome Debugger works just fine and stops the session after Chrome is stopped.

OS and Theia version: Ubuntu 19.10, Theia 1.0.0

Diagnostics: Hmm, this may be related:

Error: the debug session connection is disposed, id: 99f3c7c4-6450-4881-87a7-d33c486a9f99 debug-session-connection.ts:129:18

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptTheia debugger architectureFirefox debug extension
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the debug session lifecycle in Theia, specifically the disposal logic in debug session connection.ts. Compare with Chrome debugger implementation that handles window closure correctly. Also examine the Firefox debug extension's event handling for session termination. The error log suggests a disposed connection, so focus on how the session is notified when the target window closes.
Firefox debugger stays in 'debug' state if debugged window is closed or attach is cancelled · eclipse-theia/theia#7512 | Good First Issue