eclipse-theia/theia

better error reporting when a breakpoint cannot be set

Open

#7,499 opened on Apr 3, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
bugdapdebughelp wanted

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 12d 10h) (73 merged PRs in 30d)

Description

I can see following with debugging https://github.com/TypeFox/leeway project with go vscode extension:

Bug there are better information on returned json response in body.error:

From DAP:

If the value is false, the attribute 'message' contains the error in short form and the 'body' may contain additional information (see 'ErrorResponse.body.error').

I don't think we ever log ErrorResponse.body.error. We should check other places where we handle error responses.

Contributor guide

Research direction
Search for places in Theia's debug adapter client where DAP error responses are captured. Specifically look for where breakpoint setting occurs and ensure that `ErrorResponse.body.error` is logged in addition to the short message. The DAP spec indicates that `body.error` may contain additional details. Check all error handling paths for DAP responses. See the debug session and debug adapter protocol implementations in the Theia repository.
Tech stack
typescriptgo
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptDebug Adapter ProtocolTheia debugger
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70