eclipse-theia/theia

fix handling of workspace storage path

Open

#7472 opened on Apr 1, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedmulti-rootplug-in systemvscode

Description

Currently there are following issues:

  • path is changed for any change to a workspace, i.e. a new workspace root is added
  • path is patched on the fly

It can lead to data loss. A plugin should be sure that workspace storage path does not change for the same workspace. If a workspace is changed (not its roots) we should rather restart plugins that they load data from proper workspace storage.

We should also investigate how VS Code handle its to align with VS Code extensions' expectations.

Contributor guide

Tech stack
typescriptnodejs
Domain
backenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Theia's plugin systemFamiliarity with workspace storage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how VS Code handles workspace storage paths to align with extensions' expectations. Examine Theia's plugin system code, particularly files related to workspace storage and plugin lifecycle. Look for existing PRs or comments that discuss similar changes. Consider how to ensure the storage path remains stable for a given workspace, possibly by restarting plugins on workspace changes rather than patching paths on the fly.