eclipse-theia/theia

improve license detection for built-in extensions

Open

#7381 opened on Mar 20, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
enhancementhelp wantedvscodevsx-registry

Description

Currently we always try to look into LICENSE file, but there can be more locations including configurable.

Form @spoenemann:

  • If a package.json has SEE LICENSE IN ..., then try there first
  • after that try LICENSE.md, LICENSE, and LICENCE.txt in this order

Contributor guide

Tech stack
typescriptnodejsjavascript
Domain
backendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptNode.js file systemJSON parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Start by finding the current license detection logic, likely in a file related to extension metadata or packaging. Modify it to first check package.json for a 'SEE LICENSE IN' directive, then attempt to read LICENSE.md, LICENSE, and LICENCE.txt in order. Ensure tests are added to cover each case.