eclipse-theia/theia

NotificationContentRenderer.renderMessage: content.replace is not a function

Open

#7,367 opened on Mar 19, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedquick-openvscode

Description

Uncaught (in promise) TypeError: content.replace is not a function
    at NotificationContentRenderer.push.../../packages/messages/lib/browser/notification-content-renderer.js.NotificationContentRenderer.renderMessage (notification-content-renderer.ts:27)
    at NotificationManager.push.../../packages/messages/lib/browser/notifications-manager.js.NotificationManager.showMessage (notifications-manager.ts:170)
    at MessageService.../../packages/core/lib/common/message-service.js.MessageService.processMessage (message-service.ts:73)
    at MessageService.../../packages/core/lib/common/message-service.js.MessageService.error (message-service.ts:60)
    at quick-file-open.ts:308
  | push.../../packages/messages/lib/browser/notification-content-renderer.js.NotificationContentRenderer.renderMessage | @ | notification-content-renderer.ts:27
-- | -- | -- | --
  | push.../../packages/messages/lib/browser/notifications-manager.js.NotificationManager.showMessage | @ | notifications-manager.ts:170
  | ../../packages/core/lib/common/message-service.js.MessageService.processMessage | @ | message-service.ts:73
  | ../../packages/core/lib/common/message-service.js.MessageService.error | @ | message-service.ts:60
  | (anonymous) | @ | quick-file-open.ts:308
  | Promise.catch (async) |   |  
  | push.../../packages/file-search/lib/browser/quick-file-open.js.QuickFileOpenService.openFile | @ | quick-file-open.ts:308
  | (anonymous) | @ | quick-file-open.ts:212
  | ../../packages/core/lib/common/quick-open-model.js.QuickOpenItem.run | @ | quick-open-model.ts:94
  | push.../../packages/monaco/lib/browser/monaco-quick-open-service.js.QuickOpenEntry.run | @ | monaco-quick-open-service.ts:466
  | QuickOpenEntryGroup.run | @ | quickOpenModel.ts:281
  | QuickOpenModel.run | @ | quickOpenModel.ts:576
  | QuickOpenWidget.elementSelected | @ | quickOpenWidget.ts:587
  | (anonymous) | @ | quickOpenWidget.ts:251

Got it somehow while testing https://github.com/eclipse-theia/theia/pull/7149

@AlexTugarev I don't know how to reproduce it I was testing the tree view sample.

Contributor guide

Tech stack
typescript
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
TypeScript basicsTheia notification system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the `renderMessage` function in `notification content renderer.ts` (line 27) to understand why `content` may not be a string. Check the `MessageService` caller to ensure `content` is always a string. Look for any recent changes or comments related to this issue. Consider adding type checks or conversion before calling `.replace()`.