eclipse-theia/theia

[electron][monaco] The context menu for code actions should be native

Open

#7,365 opened on Mar 19, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bugelectronhelp wantedmonaco

Description

Description

screencast 2020-03-18 17-18-07

Reproduction Steps

OS and Theia version:

Diagnostics:

Contributor guide

Tech stack
typescriptelectron
Domain
frontenddesktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptElectron native menusTheia menu system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how context menus are currently implemented in Theia's Electron shell. Look at the `packages/core/src/electron browser/menu` directory for existing native menu integration. The Monaco editor's context menu is likely overridden; consider using Electron's `Menu.buildFromTemplate()` to create a native menu from the code actions. Check any existing PRs or discussions about native menus in Theia.