eclipse-theia/theia

theming: revisit uses of 'successBackground' color

Open

#7,364 opened on Mar 18, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
help wantedtheming

Description

Motivation

https://github.com/eclipse-theia/theia/pull/7351#discussion_r394392282

Description

We should revisit the use of the successBackground across the application. successBackground is a custom color which does not exist in vscode and may cause problems when attempting to change themes. If the color is not present in vscode, we can argue if it is really required in the application.

https://github.com/eclipse-theia/theia/blob/f015148a680e3c5ca892a6050b7cd8d86e03f413/packages/core/src/browser/common-frontend-contribution.ts#L1597-L1603

In addition, the color only gets a default value from the scm extension which means that if it is not included, areas such as markers will not have any coloring for this value:

https://github.com/eclipse-theia/theia/blob/f015148a680e3c5ca892a6050b7cd8d86e03f413/packages/scm/src/browser/scm-contribution.ts#L199-L204

Contributor guide

Tech stack
typescriptcss
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptCSS themingVS Code color conventions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Search the codebase for all uses of 'successBackground' string. Refer to the discussion in PR #7351 for context. Examine each usage in the referenced files (e.g., common frontend contribution.ts and scm contribution.ts) to determine if the color can be replaced with a VS Code standard color or if a new approach is needed. Propose changes in a new pull request.