eclipse-theia/theia

theming: add guards to prevent overriding default monaco coloring

Open

#7,363 opened on Mar 18, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
help wantedmonacoqualitytheming

Description

Motivation:

https://github.com/eclipse-theia/theia/pull/7351#issuecomment-600658398

Description

There should be guards in place to prevent overriding monaco coloring. Monaco defines it's own colors which are used across the application, and it is possible to override such colors which may cause theming issues. Guards should be put in place to prevent such overriding such as to discard updates and log them.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Theia theming systemMonaco editor colorsTypeScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Start by reviewing PR #7351 and its discussion, especially the linked comment. Understand how Monaco colors are currently defined and overridden in Theia's theming system. Look for areas where color definitions are applied without validation, and implement logic to log and discard attempts to override default Monaco colors. The relevant files are likely in the theming or monaco related packages.