eclipse-theia/theia

Drag & drop files into the file explorer depends on expand/collapse status

Open

#7,360 opened on Mar 18, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bugdndhelp wantednavigator

Description

Hi,

Description

Drag & drop files into the file explorer depends on expand/collapse status of the folders. If the folders are expanded then some files are copied twice into the file explorer.

Reproduction Steps

On your file system create a folder with some sub folders and files in each level. Expand all folders and drag all of the folders and files to the file explorer. You would be able to see some files are copied twice. You can view the attached video to see the issue.

OS and Theia version: Mac. Reproduced on https://gitpod.io/#https://github.com/eclipse-theia/theia theiadragdropbug.mp4.zip

Thanks, Liat

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptTheia file explorer internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the drag and drop logic in Theia's file explorer widget. Check the event handlers for dropped files when the folder tree is expanded. The attached video shows the bug. Look for duplicate insertion of files when folders are expanded. Focus on the drop event handling code in the file explorer component.