eclipse-theia/theia

Add an option to render custom icon templates for menus

Open

#6,888 opened on Jan 15, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
enhancementhelp wantedmenusproposal

Description

Description

Right now, the only way to set an icon for a menu is to set icon property and that only sets the classname. Currently, It's not possible to provide a custom html template for it.

Contributor guide

Tech stack
typescriptreacthtml
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Theia's menu renderingTypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Look into the menu icon rendering logic in Theia's core, particularly in packages/core/src/browser/menu/. The current implementation only accepts a classname for the 'icon' property. To support custom HTML templates, you'll need to extend the menu item interface and modify the rendering component to allow raw HTML. Check existing tests in the same directory and consider adding new tests. There are no linked PRs, so this is open for contribution.