eclipse-theia/theia

Quickpick doesn't work when items are updated

Open

#6,626 opened on Nov 25, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedquick-openvscode

Description

I'm trying to test the asExternalUri support using the instructions from @akosyakov at https://github.com/eclipse-theia/theia/pull/6465#issuecomment-556072510 (though I'm using the master branch since that PR is now merged).

When the Dart extension opens the device picker (either by trying to launch an app or clicking on the device label in the status bar) the selector appears but it's impossible to select an item (either with the keyboard or the mouse):

Screenshot 2019-11-25 at 3 51 16 pm

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Familiarity with Theia's Quickpick widgetUnderstanding of async item updates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the referenced PR #6465 and the Quickpick item update mechanism. Look at the QuickOpenService and how items are refreshed. Check the handling of selection after items are updated, likely in packages/core/src/browser/quick open/quick open widget.ts.