eclipse-theia/theia

[vscode] language client cannot access configurations by first segment

Open

#6,344 opened on Oct 8, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedpreferencesvscode

Description

It is reproducible with sample VS Code extension: https://github.com/microsoft/vscode-extension-samples/tree/master/lsp-sample

An extension should produce diagnostics for upper-case worlds, but it does not. By looking at logs one can see that the server fails with cannot read a property of null. It happens because Theia does not properly return a default value for the first segment, i.e. a language client id.

Contributor guide

Tech stack
typescriptnodejs
Domain
backenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptVS Code extension samplesLanguage Server Protocol basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is reproducible using the standard LSP sample extension from VS Code. To fix, investigate how Theia's language client handles configuration requests, specifically the first segment of the configuration key. Compare with VS Code's implementation to understand the expected default value behavior. Focus on the code that processes configuration sections in the language client.