eclipse-theia/theia

[vscode] language client cannot access configurations by first segment

Open

#6,344 opened on Oct 8, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,478 forks)batch import
bughelp wantedpreferencesvscode

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

It is reproducible with sample VS Code extension: https://github.com/microsoft/vscode-extension-samples/tree/master/lsp-sample

An extension should produce diagnostics for upper-case worlds, but it does not. By looking at logs one can see that the server fails with cannot read a property of null. It happens because Theia does not properly return a default value for the first segment, i.e. a language client id.

Contributor guide

Research direction
Trace the configuration retrieval code path for the language client to understand why the first segment returns null.
Tech stack
typescript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75