eclipse-theia/theia

Improve the "file has been changed" dialog

Open

#5,831 opened on Jul 31, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
filesystemhelp wantedui/ux

Description

Screen Shot 2019-07-31 at 13 08 48

  • the title is too long
  • the buttons should be something like Replace | Keep | Cancel

Contributor guide

Tech stack
typescriptcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Theia's dialog system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue proposes changing the dialog title and buttons to 'Replace', 'Keep', 'Cancel'. Look in the Theia source code for the dialog implementation, likely under `packages/core/src/browser/dialogs`. Search for the current string 'file has been changed' and the button labels. Review the dialog's widget class to understand how to modify the title and buttons. Test the change by running Theia and triggering the dialog.