eclipse-theia/theia

@theia/task Doesn't run task, creates new terminal

Open

#5,825 opened on Jul 31, 2019

View on GitHub
 (12 comments) (1 reaction) (0 assignees)TypeScript (2,478 forks)batch import
bughelp wantedtasks

Repository metrics

Stars
 (18,676 stars)
PR merge metrics
 (Avg merge 15d 4h) (75 merged PRs in 30d)

Description

Description

Terminal/Run task does not execute the example tasks in the tasks readme. Instead, it opens new terminals. To verify it wasn't my environment, I spun up a vm in gcloud with a bash environment. Here are some gifs to demonstrate:

  • On my zsh environment:

theiaTaskIssue

  • On the gcloud bash environment:

theiaTaskIssue2

Reproduction Steps

This is while developing my own extension, so to be sure I started a new "hello world" extension project using the tutorial steps. Then I go into "browser-app", execute:

yarn add @theia/task

to add the extension. I also tried running yarn add in my extension directory.

Restart the project and try to run a task.

OS and Theia version:

  • zsh environment:

Linux pop-os 5.0.0-21-generic #22+system76-Ubuntu SMP Tue Jul 16 19:57:52 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

-gcloud bash environment:

Linux 4.9.0-9-amd64 #1 SMP Debian 4.9.168-1+deb9u3 (2019-06-16) x86_64 GNU/Linux

Diagnostics: There the errors that I see: :

0|api | root WARN Collided keybinding is ignored; {"command":"outlineView:toggle","keybinding":"ctrlcmd+shift+s"} collided with {"command":"file.saveAs","keybinding":"ctrl+shift+s"} 0|api | root WARN Could not register keybinding: 0|api | {"command":"outlineView:toggle","keybinding":"ctrlcmd+shift+s"} 0|api | Error: "ctrlcmd+shift+s" is in collision with something else [scope:0] 0|api | root WARN Collided keybinding is ignored; {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"} collided with {"command":"terminal:clear","keybinding":"ctrlcmd+k","context":"terminalActive"} 0|api | root WARN Could not register keybinding: 0|api | {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"} 0|api | Error: "ctrl+k" is in collision with something else [scope:0] 0|api | root WARN e.onStart is slow, took: 108.82500000298023 ms 0|api | root WARN e.onStart is slow, took: 1282.455000007758 ms 0|api | root ERROR Error(s) reading config file: file:///home/david/georq_workspace/.theia/tasks.json 0|api | root ERROR Couldn't resize terminal -1, because it doesn't exist. 0|api | root ERROR Couldn't resize terminal -1, because it doesn't exist. 0|api | terminal ERROR Couldn't attach - can't find terminal with id: 12 0|api | terminal ERROR Error attaching to terminal id 12, the terminal is most likely gone. Starting up a new terminal instead.

On the zsh environment it is a little more verbose:

Started watching: /home/david/src/map_workspace/.theia/tasks.json task INFO Created new task, id: 0, process id: 10, OS PID: 14940, context: file:///home/david/src/map_workspace terminal ERROR Couldn't attach - can't find terminal with id: 10 root ERROR Couldn't resize terminal -1, because it doesn't exist. terminal ERROR Error attaching to terminal id 10, the terminal is most likely gone. Starting up a new terminal instead.

So clearly, the task extension cannot find the current terminal and then starts a new terminal, but doesn't run the task either way.

Contributor guide