eclipse-theia/theia

Get rid of TerminalWidgetImpl

Open

#5,660 opened on Jul 8, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
help wantedqualityterminal

Description

It should be just TerminalWidget. If we want to abstract over different terminals, we should introduce Terminal interfaces and hide xterm behind it for TerminalWidget. We don't need another implementation of TerminalWidget itself.

Contributor guide

Tech stack
typescript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptTheia terminal widget structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current implementation of TerminalWidget and TerminalWidgetImpl in the Theia source code, likely under packages/terminal. Identify all usages of TerminalWidgetImpl and plan to replace them with TerminalWidget. Consider introducing a Terminal interface to abstract xterm. Look for existing tests for the terminal widget to ensure the refactor doesn't break functionality. The maintainers have not provided additional comments, so the contributor should propose a design in a comment before implementing.