eclipse-theia/theia

[process] On Linux, when Theia is closed from the UI, its process is not killed

Open

#5,644 opened on Jul 4, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
OS/Linuxbugelectronhelp wanted

Description

Description

On Linux, when Theia is run from the terminal and the application gets closed by the user from the UI, the Theia process is kept alive. Ctrl C is needed to kill the process.

Reproduction Steps

Try to compile and run Theia on desktop (on Linux) by using yarn start and then click on the X icon to close the program. The process in the Terminal is not killed.

OS and Theia version:

Diagnostics:

Not sure if referred to the main Theia process or to subprocess but this is the output printed when Theia gets closed from the UI:

process WARN This process was not registered or was already unregistered. [ID: 0]

Contributor guide

Tech stack
typescriptnodejselectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Electron app lifecycleNode.js process handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Start by examining the process management code in Theia's backend, particularly the unregistration and cleanup logic. Look for files related to process lifecycle (e.g., process.ts or application.ts). The warning 'This process was not registered or was already unregistered' indicates a missing registration or duplicate unregistration. Check how the desktop application handles the 'close' event and ensures all child processes are killed. Review the issue comments for any additional debugging hints.