eclipse-theia/theia

[plugin] Cannot read property 'subscriptions' of undefined

Open

#5,626 opened on Jul 3, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedplug-in system

Description

I can reproduce it with https://github.com/sstone1/che-plugin-registry/releases/download/0.0.1/ibm-blockchain-platform-1.0.3.vsix

root ERROR [hosted-plugin: 1970] (node:1970) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'subscriptions' of undefined
    at disposeExtension (/tmp/vscode-unpacked/ibm-blockchain-platform-1.0.3.vsix/extension/out/src/extension.js:319:13)
    at ActivatedPlugin.<anonymous> (/tmp/vscode-unpacked/ibm-blockchain-platform-1.0.3.vsix/extension/out/src/extension.js:209:9)
    at Generator.next (<anonymous>)
    at fulfilled (/tmp/vscode-unpacked/ibm-blockchain-platform-1.0.3.vsix/extension/out/src/extension.js:17:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

It seems to happen when the window is closed.

Contributor guide

Tech stack
typescript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the error in the disposeExtension function at line 319 of extension.js. The error suggests that the 'subscriptions' property is undefined when attempting to dispose of a plugin upon window close. Review the plugin lifecycle code in the Theia repository, possibly in packages/plugin or similar. Consider adding a null check or ensuring subscriptions is initialized before disposal. Also check if there are any related issues or PRs.